Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send bot start/stop messages to slack channel #3

Merged
merged 3 commits into from Jan 3, 2019

Conversation

PrasadG193
Copy link
Collaborator

Fixes: #2

  • Send bot start/stop messages to slack channel
  • Fix timestamps in delete notifications

@PrasadG193 PrasadG193 changed the base branch from master to develop January 2, 2019 08:46

func sendMessage(msg string) {
if len(msg) <= 0 {
return
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log warning here

notifier.SendEvent(event)
}

func sendMessage(msg string) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep this function in notifier package

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ssudake21 we already have notifier.SendMessage(msg) function in notifier package

@sanketsudake sanketsudake merged commit 55f636f into develop Jan 3, 2019
@PrasadG193 PrasadG193 deleted the fix-notification-msgs branch January 4, 2019 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants